-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: rwds-276 show rewards balance #37361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0d38064]
UI Startup Metrics (1272 ± 83 ms)
|
0d38064 to
b1f1847
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [b1f1847]
UI Startup Metrics (1280 ± 76 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
b1f1847 to
e43a1b9
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e43a1b9]
UI Startup Metrics (1284 ± 85 ms)
|
e43a1b9 to
08dc827
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [08dc827]
UI Startup Metrics (1240 ± 77 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
I have read the CLA Document and I hereby sign the CLA |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [979f7ea]
UI Startup Metrics (1258 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
9e54f7f to
dbdf7b3
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [dbdf7b3]
UI Startup Metrics (1255 ± 88 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [aa517e9]
UI Startup Metrics (1269 ± 104 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
b0e0de6 to
7011f97
Compare
8856f44 to
7a4fe52
Compare
Builds ready [7a4fe52]
UI Startup Metrics (1287 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
✨ Files requiring CODEOWNER review ✨💎 @MetaMask/metamask-assets (2 files, +4 -4)
|
9f7310e to
51c1acb
Compare
Builds ready [657c8d2]
UI Startup Metrics (1245 ± 145 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
657c8d2 to
ceb777f
Compare
Builds ready [586c5f0]
UI Startup Metrics (1257 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
bergarces
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replacing the portfolio button with the rewards icon 👍
Pull Request is not mergeable
Description
Changelog
CHANGELOG entry: show rewards balance
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/RWDS-276
Screenshots/Recordings
After
TODO
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Displays a Rewards points badge next to balance change when rewards is enabled, backed by new Rewards hooks/context and controller wiring; simplifies related UI, removes Shield deep link/flows, and updates infra and tests.
RewardsPointsBalancecomponent and icon; show it instead of the Portfolio button via newtrailingChildprop in balance/overview components.RewardsProviderand hooks (useRewardsEnabled,useCandidateSubscriptionId,useSeasonStatus) with tests; adduseRewardsContextand wrap app routes.getCandidateSubscriptionId,getSeasonMetadata/Status).RewardsController: shorter not-opted-in cache TTL, stricter token/session handling, improved flattening, reset subscription tokens on invalidation; expand tests.reduce/spread in multiple modules; simplify selectors and utilities; narrowsanitizeStringto LTR/RTL overrides.Written by Cursor Bugbot for commit ceb777f. This will update automatically on new commits. Configure here.